Opened 11 years ago

Closed 9 years ago

Last modified 8 years ago

#8923 closed defect (fixed)

ComboBox: clicking arrow icon on disabled ComboBox focuses it

Reported by: bill Owned by: bill
Priority: high Milestone: 1.5
Component: Dijit - Form Version: 1.3.0b3
Keywords: Cc: Douglas Hays
Blocked By: Blocking:

Description

See test_ComboBox.html. On the ComboBox labeled "Initially disabled", click not over the input area but over the arrow icon. The combobox itself gets an outer focus border.

I'll check in a test case to dijit/tests/form/robot/_autoComplete.html but commented out until this ticket is fixed.

Likely a manifestation of #8595, but keeping as a separate ticket so we remember to uncomment the test case.

Tested on FF3/mac.

Change History (6)

comment:1 Changed 10 years ago by Becky Gibson

Cc: Douglas Hays added
Component: AccessibilityDijit
Owner: Becky Gibson deleted

comment:2 Changed 10 years ago by bill

Milestone: tbd1.5

comment:3 Changed 9 years ago by bill

Milestone: 1.51.6

comment:4 Changed 9 years ago by bill

Milestone: 1.61.5
Owner: set to bill
Status: newassigned

Changed my mind, will fix this for 1.5.

comment:5 Changed 9 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [22011]) Fixes so that disabled widgets don't get focus by mouse or keyboard:

  • Made focus manager ignore click events on disabled widgets. It still responds to actual focus events so that Menu still works (which focuses the disabled MenuItems). Clicking a disabled dijit.form.Button in an enabled TabContainer will call onFocus() on the TabContainer (and the ContentPane) but not the Button.
  • Fixed _FormWidget._setDisabledAttr() to set/remove tabIndex on all focusable nodes. Usually only focusNode is focusable, but ComboButton has two focusable nodes. Disabling a widget now sets tabIndex=-1 on nodes like <button> but removes tabIndex on nodes like <div>.
  • Added new method dijit.hasDefaultTabStop() to support above code.

The only remaining problem is webkit, where clicking widgets still gives them focus, but this is a webkit bug that doesn't seem feasible to workaround. I did add workaround code for webkit so at least keyboard works correctly, by using tabIndex=-1 instead of removing tabIndex (see #11064 for details).

Fixes #8903, #8923, #8595, #11053, refs #11064 !strict.

comment:6 Changed 8 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.