regression [dojox] ColorPicker

[dante]

ColorPicker stopped working all together. First appears broken on Feb 2: ​http://archive.dojotoolkit.org/dojo-2009-02-02/dojotoolkit/dojox/widget/tests/test_ColorPicker.html

Unfortunately, nightly's weren't running, so the last time it was there and working was the last available nightly prior:

​http://archive.dojotoolkit.org/dojo-2009-01-24/dojotoolkit/dojox/widget/tests/test_ColorPicker.html

looking through the timeline for the potential days shows only one suspect checkin: [16468] Nothing else seems to touch anything about colorpicker. It only inherits from _FormWidget, but used dojox.color, though dojox.color has gone unchanged since well before 1-24-2009

[dante]

this might not be _FormWidget related at all, but having a hard time determining what changed. there are marginBox calls in buildRendering which are now reporting 0 for all sizes which seems to be causing the problem.

[dante]

ugh okay - so what changed? colorpicker was using buildrendering because it needs to do this size calculation because _setValueAttr is called before postCreate and the sizes and offsets calculated are relevant to the value. If I change buildrendering to postCreate and make _setValueAttr check this._started before continuing, the widget works again.

Did something in the lifecycle change in those days? Something regarding visibility/display? I'm not seeing it, and this fix seems janktastic.

[dante]

proposed solution, though I don't like it.

[Douglas Hays]

bill moved this._applyAttributes() out of buildRendering and into create(), just after the call to buildRendering().

[bill]

In theory you should be doing all the sizing and things related to sizing in startup() because that's the only time you can be sure that you are attached to the document. new dojox.widget.ColorPicker() will fail if it tries to do any marginBox() calls. So I'd suggest that. That's how dijit does it.

[dante]

in [17052]