Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#8906 closed defect (fixed)

[regression] [IE7]dojo.byId failed after cloning node

Reported by: jfcunat Owned by: James Burke
Priority: high Milestone: 1.3
Component: Core Version: 1.3.0b3
Keywords: dojo.byId Cc:
Blocked By: Blocking:

Description (last modified by bill)

When you clone a node and then change the id of the cloned node, dojo.byId fails to get the new node by its id. document.getElementById works.

This was not the case before Changeset [16465]

The problem comes from these lines

if(te.attributes && te.attributes.id && te.attributes.id.value == id){ 
    return te
} 

where te.attributes.id still refers to initial id.

This bug makes dojo.dnd with copyOnly option not working on IE7. When you copy a node you can't move it afterwards.

Attachments (1)

test_html_dojoByIdIE7.html (946 bytes) - added by jfcunat 11 years ago.

Download all attachments as: .zip

Change History (5)

Changed 11 years ago by jfcunat

Attachment: test_html_dojoByIdIE7.html added

comment:1 Changed 11 years ago by Adam Peller

Owner: changed from anonymous to James Burke

comment:2 Changed 11 years ago by bill

Description: modified (diff)
Summary: [IE7]dojo.byId failed after cloning node[regression] [IE7]dojo.byId failed after cloning node

comment:3 Changed 11 years ago by James Burke

Resolution: fixed
Status: newclosed

Fixed in [17054]

comment:4 Changed 11 years ago by James Burke

Did a simpler fix in [17080]: "a cleaner fix for cloned nodes that has their IDs changed. Added test case for testing the 'form with child element that shows up as an id property on the form."

Note: See TracTickets for help on using tickets.