Opened 11 years ago

Closed 11 years ago

Last modified 9 years ago

#8905 closed enhancement (fixed)

Button: showLabel doesn't work after initialization

Reported by: knp Owned by:
Priority: high Milestone: 1.4
Component: Dijit - Form Version: 1.2.3
Keywords: button label accessibility Cc:
Blocked By: Blocking:

Description

on initializing a button, setting showLabel to true or false controls the display of the text label. However, after the button is instantiated:

var b = dijit.ById("button");
dojo.attr(b, "showLabel", "false");

or

dijit.setAttribute(b, "showLabel", "false");

and other combinations do not work.

Change History (4)

comment:1 Changed 11 years ago by bill

Summary: button showLabel not working after initializationButton: showLabel doesn't work after initialization
Type: defectenhancement

That's true, that's a current limitation, should move the showLabel code from postCreate() into a custom _setShowLabelAttr() setter.

Could also just document showLabel as [const], but might as well support changing it after initialization.

comment:2 Changed 11 years ago by bill

Milestone: tbd1.4

comment:3 Changed 11 years ago by bill

Resolution: fixed
Status: newclosed

(In [17379]) Move showLabel logic to custom attribute setter so that showLabel attribute can be toggled after initialization. Fixes #8905 !strict.

comment:4 Changed 9 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.