Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#8902 closed defect (fixed)

Constant used instead of variable in filestore_funcs.php

Reported by: Simon Speich Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.3
Component: DojoX Data Version: 1.3.0b3
Keywords: PHP, FileStore Cc:
Blocked By: Blocking:

Description

The dojox data store 'FileStore?' in the demo communicates with the PHP file 'filestore_tree.php or 'filestore_dojoxdata.php'. Those include the file 'filestore_funcs.php' which generates the error multiple times:

Use of undefined constant showHiddenFiles.

This can easily be fixed by searching and replacing all occurences of !showHiddenFiles with !$showHiddenFiles, e.g. make showHiddenFiles a PHP variable and not a constant by prepending the dollar sign.

Attachments (1)

filestore_fix.patch​ (7.5 KB) - added by Jared Jurkiewicz 13 years ago.
Patch for the problem. There fix was not as simple as replace, it was a logic typo (! instead of $), and I fixed two other undefined prop errors I hit while testing.

Download all attachments as: .zip

Change History (3)

Changed 13 years ago by Jared Jurkiewicz

Attachment: filestore_fix.patch​ added

Patch for the problem. There fix was not as simple as replace, it was a logic typo (! instead of $), and I fixed two other undefined prop errors I hit while testing.

comment:1 Changed 13 years ago by Jared Jurkiewicz

Resolution: → fixed
Status: new → closed

Fixed in changeset: [17104]

comment:2 Changed 13 years ago by Adam Peller

Milestone: tbd → 1.3

batch move of tickets marked 'tbd' fixed in the 1.3 timeframe

Note: See TracTickets for help on using tickets.