Opened 11 years ago

Closed 11 years ago

#8899 closed enhancement (fixed)

[patch] [cla] Lightbox: Added underlay click with modal option

Reported by: gacord Owned by: dante
Priority: high Milestone: 1.4
Component: Dojox Version: 1.3.0b3
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by dante)

fixed in [17205] -- thanks gary for the patch!

Attachments (2)

lightboxpatch.diff (1.7 KB) - added by gacord 11 years ago.
lightboxpatch2.diff (1.6 KB) - added by gacord 11 years ago.
lightboxpath2 is the most recent file. this was redone to allow for the last minute 1.3 fixes to lightbox.

Download all attachments as: .zip

Change History (8)

Changed 11 years ago by gacord

Attachment: lightboxpatch.diff added

comment:1 Changed 11 years ago by bill

Component: GeneralDojoX Widgets
Milestone: 1.3tbd
Owner: changed from anonymous to dante
Summary: Added underlay click with modal option to LightboxLightbox: Added underlay click with modal option

comment:2 Changed 11 years ago by bill

Component: DojoX WidgetsDojox
Owner: changed from dante to Adam Peller
Summary: Lightbox: Added underlay click with modal option[patch] [cla] Lightbox: Added underlay click with modal option

comment:3 Changed 11 years ago by dante

Milestone: tbd1.4
Owner: changed from Adam Peller to dante
Status: newassigned

debugging needs to go, but otherwise seems okay. I might be more explicit about the summary of the 'modal' option, and also ensure it means the same thing as it does in dojox.widget.Dialog

comment:4 Changed 11 years ago by gacord

my bad, forgot the debugging was still there. made the comments a bit more clear. this "modal" isn't quite the same as dialog, I left the ability to close with ESC.

Changed 11 years ago by gacord

Attachment: lightboxpatch2.diff added

lightboxpath2 is the most recent file. this was redone to allow for the last minute 1.3 fixes to lightbox.

comment:5 Changed 11 years ago by gacord

redid changes from trunk, allowing for 1.3 resize fixes

comment:6 Changed 11 years ago by dante

Description: modified (diff)
Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.