Opened 11 years ago
Closed 11 years ago
#8899 closed enhancement (fixed)
[patch] [cla] Lightbox: Added underlay click with modal option
| Reported by: | gacord | Owned by: | dante |
|---|---|---|---|
| Priority: | high | Milestone: | 1.4 |
| Component: | Dojox | Version: | 1.3.0b3 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description (last modified by )
fixed in [17205] -- thanks gary for the patch!
Attachments (2)
Change History (8)
Changed 11 years ago by
| Attachment: | lightboxpatch.diff added |
|---|
comment:1 Changed 11 years ago by
| Component: | General → DojoX Widgets |
|---|---|
| Milestone: | 1.3 → tbd |
| Owner: | changed from anonymous to dante |
| Summary: | Added underlay click with modal option to Lightbox → Lightbox: Added underlay click with modal option |
comment:2 Changed 11 years ago by
| Component: | DojoX Widgets → Dojox |
|---|---|
| Owner: | changed from dante to Adam Peller |
| Summary: | Lightbox: Added underlay click with modal option → [patch] [cla] Lightbox: Added underlay click with modal option |
comment:3 Changed 11 years ago by
| Milestone: | tbd → 1.4 |
|---|---|
| Owner: | changed from Adam Peller to dante |
| Status: | new → assigned |
comment:4 Changed 11 years ago by
my bad, forgot the debugging was still there. made the comments a bit more clear. this "modal" isn't quite the same as dialog, I left the ability to close with ESC.
Changed 11 years ago by
| Attachment: | lightboxpatch2.diff added |
|---|
lightboxpath2 is the most recent file. this was redone to allow for the last minute 1.3 fixes to lightbox.
comment:6 Changed 11 years ago by
| Description: | modified (diff) |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
debugging needs to go, but otherwise seems okay. I might be more explicit about the summary of the 'modal' option, and also ensure it means the same thing as it does in dojox.widget.Dialog