Opened 10 years ago

Closed 10 years ago

#8894 closed defect (fixed)

ondijitclick not working on FF variants

Reported by: bill Owned by: Becky Gibson
Priority: high Milestone: 1.4
Component: Accessibility Version: 1.3.0b3
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

Probably the dojo.isFF checks in the ondijitclick code (in _Widget.js) should be changed to dojo.isMoz, so that it works on iceweasel etc. Presumably it doesn't work now, although I haven't tested it.

Change History (5)

comment:1 Changed 10 years ago by James Burke

I committed a fix attached to ticket #8895 that expands detection for firefox-like browsers but it is incomplete, I do not test for iceweasel.

We need a more robust fix in Dojo 1.4, an isGecko, that could use the gecko date perhaps. In addition to removing useragent detection where possible. But note that isMoz only gives the Mozilla/5.0 number, something that may not be as granular as you need.

comment:2 Changed 10 years ago by bill

Description: modified (diff)
Summary: ondijitclick and isFF checksondijitclick not working on FF variants

In this case it's just doing dojoisFF (i.e. checking for any version of firefox) so we should be ok with just dojo.isMoz, I think.

comment:3 Changed 10 years ago by Becky Gibson

Milestone: tbd1.3.1

comment:4 Changed 10 years ago by Adam Peller

Milestone: 1.3.11.4

We've got these sorts of issues throughout the code, so let's not make an exception for the branch.

comment:5 Changed 10 years ago by bill

Resolution: fixed
Status: newclosed

This was fixed already in [17832], when the FF checking was removed from the ondijitclick code. Turns out it wasn't necessary.

Note: See TracTickets for help on using tickets.