Opened 10 years ago

Closed 10 years ago

#8881 closed defect (fixed)

[PATCH][CCLA]Column header text moves to the right when sorting column in IE6

Reported by: Jared Jurkiewicz Owned by: Bryan Forbes
Priority: high Milestone: 1.3.1
Component: DojoX Grid Version: 1.2.3
Keywords: Cc:
Blocked By: Blocking:

Description

From a co-worker:

This is seen using Dojo 1.2.3 on IE6 with the test at http://download.dojotoolkit.org/release-1.2.3/dojo-release-1.2.3/dojox/grid/tests/test_data_grid.html. If you sort on either column the header text is moved slightly to the right. Sorting on the other column will remove the sort arrow on the previous column and the header text moves back to the left. This wouldn't be a big deal normally but our app uses the header in a certain way that makes this very noticeable.

Attachments (2)

ie6_headershift.patch (984 bytes) - added by Jared Jurkiewicz 10 years ago.
Patch to wrap the header text in a div that is floated to solve the shift. (Ie6 only applied)
ie6_sortheader_better.patch (1.3 KB) - added by Jared Jurkiewicz 10 years ago.
A simpler (and better) patch for the header shifting issue. All CSS, simple margin kill since margins don't appear to float with the node.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 10 years ago by Jared Jurkiewicz

Component: GeneralDojoX Grid
Owner: changed from anonymous to Bryan Forbes

comment:2 Changed 10 years ago by Jared Jurkiewicz

Version: 1.3.0b31.2.3

comment:3 Changed 10 years ago by Jared Jurkiewicz

This is completely an IE6 bug. I think I have a workaround for it. Patch is coming.

Changed 10 years ago by Jared Jurkiewicz

Attachment: ie6_headershift.patch added

Patch to wrap the header text in a div that is floated to solve the shift. (Ie6 only applied)

comment:4 Changed 10 years ago by Jared Jurkiewicz

I've got a product team testing this now.

comment:5 Changed 10 years ago by Jared Jurkiewicz

Summary: Column header text moves to the right when sorting column in IE6[PATCH][CCLA]Column header text moves to the right when sorting column in IE6

comment:6 Changed 10 years ago by bill

Milestone: tbd1.4

1.3rc1 has been release; bumping remaining tickets to 1.4 (except for documentation/testing tickets)

comment:7 Changed 10 years ago by Jared Jurkiewicz

There may be a simpler fix for this (completely CSS).

In tundraGrid.css (And the others, there's a section that sets the sort arrow image.

For IE6, the left padding needs to be killed.

For example:

.dj_ie6 .tundra .dojoxGridArrowButtonNode {

background-image:url("../../../dijit/themes/tundra/images/spriteArrows.gif"); margin-left: 0px;

}

I did that marget left set, and I no longer that that idiotic indent IE6 does when the sort arrow is inserted. Apparently on Ie6, margins aren't floated over with the node or something.

Changed 10 years ago by Jared Jurkiewicz

Attachment: ie6_sortheader_better.patch added

A simpler (and better) patch for the header shifting issue. All CSS, simple margin kill since margins don't appear to float with the node.

comment:8 Changed 10 years ago by Jared Jurkiewicz

Milestone: 1.41.3.1

I'd like to get this into 1.3.1 if possible. Its minor and does improve the grid on IE6

comment:9 Changed 10 years ago by Jared Jurkiewicz

Checked into trunk [17138]

Will put in 1.3.1 branch when that is available.

comment:10 Changed 10 years ago by Adam Peller

1.3 branch is ready

comment:11 Changed 10 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

(In [17296]) Minor CSS fix to grid for header shifting. Fixes #8881

Note: See TracTickets for help on using tickets.