Opened 10 years ago

Closed 10 years ago

#8876 closed defect (fixed)

Dialog and ContentPane don't call this.inherited(arguments) in their uninitialize() functions.

Reported by: jekser Owned by: bill
Priority: high Milestone: 1.4
Component: Dijit Version: 1.3.0b3
Keywords: dijit.layout.ContentPane, dijit.Dialog, uninitialize Cc:
Blocked By: Blocking:

Description

dijit.layout.ContentPane? and dijit.Dialog don't call this.inherited(arguments) in their uninitialize() functions.

So if you extend the dijit._Widget class, and connect to the _Widget.uninitialize() function, this code don't apply to dijit.layout.ContentPane? and dijit.Dialog.

Change History (2)

comment:1 Changed 10 years ago by bill

Milestone: tbd1.4
Owner: set to bill

Are you connecting to _Widget.prototype.unitialize? Or just myWidget.uninitialize?

In any case I'll fix the missing this.inherited() callls. (There are also some other missing calls in the code that I'll add.)

comment:2 Changed 10 years ago by bill

Resolution: fixed
Status: newclosed

(In [17391]) Add missing this.inherited() calls. Fixes #8876 !strict.

Note: See TracTickets for help on using tickets.