MenuItem: Accelerator keys need infrastructure

[Joseph Scheuhammer]

While testing menus for keyboard a11y, I noticed that some menu items have acceelerator keys. They did not work.

The reason is: while MenuItem.js provides a way to specify the accelerator key combination, there isn't any analogous way to connect a handler for the key-combo. In fact, there is a comment in the code: "... there is no infrastructure to actually catch and execute these accelerators". See also #8322.

I have a misgiving about this. It's misleading in that the ability to specify the accelerator key suggests that that is all that is needed, when in fact doing so has no effect. If this is a future feature, then developers need a warning that this infrastructure is missing.

FWIW, I'd like to see something along the lines of a method such as:

setAccelKeyHandler(/*String*/ accelKey, /*Object|null*/ context, /*Function*/ handler)

It should a method of some basic object (_Widget.js?) since widgets other than menu items might have accelerator keys, for example, Buttons.

[dante]

n00bish question, but what about accesskey ... is that already accounted for wrt to ARIA? can we reuse that and normalize it ala onDijitClick on a per-instance basis?

[bill]

Yup, this is explained in the API doc:

// accelKey: String
//		Text for the accelerator (shortcut) key combination.
//		Note that although Menu can display accelerator keys there
//		is no infrastructure to actually catch and execute these
//		accelerators.
accelKey: "",

and is listed already in #6423 more or less.

Rawld Gill ​offered to contribute an infrastructure for this so waiting on that.