Opened 10 years ago

Closed 7 years ago

#8853 closed defect (fixed)

dojo.dnd.autoscroll getViewport algorithm in Opera 9.64

Reported by: Łukasz Krzyżak Owned by: Eugene Lazutkin
Priority: high Milestone: 1.6
Component: DnD Version: 1.3.0b2
Keywords: Cc:
Blocked By: Blocking:

Description

in #8421 getting viewport size by dijit.getViewport was fixed to work in Opera 9.64

unfortunately, dojo.dnd.autoscroll.getViewport uses old algorithm, which doesn't work properly in my application.

dijit.getViewport doesn't depend on any methods from dijit, so why not move this implementation into dojo, and use it in both places ?

Change History (4)

comment:1 Changed 10 years ago by bill

Moving getViewport() to core is already listed in #7028, just needs to be done. (Of course, could also fix dojo.dnd's getViewport(), but moving is better in the long term.)

comment:2 Changed 10 years ago by Eugene Lazutkin

Milestone: tbdfuture

Yes, I agree that we should eliminate the duplication. Please move getViewport() and I'll update the DnD code accordingly.

comment:3 Changed 7 years ago by Eugene Lazutkin

Bill, was getViewport() moved?

comment:4 Changed 7 years ago by bill

Milestone: future1.6
Resolution: fixed
Status: newclosed

Yes, getBox() in dojo/window.js, and actually I removed the duplicated code in autoscroll.js in [22985], so we can mark this as fixed.

Last edited 7 years ago by bill (previous) (diff)
Note: See TracTickets for help on using tickets.