#8844 closed defect (fixed)
[PATCH][CCLA] Grid incorrectly closes <th> cells when creating header.
| Reported by: | Jared Jurkiewicz | Owned by: | Bryan Forbes |
|---|---|---|---|
| Priority: | high | Milestone: | 1.3 |
| Component: | DojoX Grid | Version: | 1.3.0b2 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
Grid incorrectly closes <th> cells when creating header.
I was actually investigating another bug when I uncovered this one.
In dojox/grid/_Builder.js:
Function: generateCellMarkup:
At the start of the function, you have the following check:
if(isHeader){
var sortInfo = inCell.index != inCell.grid.getSortIndex() ? "" : inCell.grid.sortInfo > 0 ? 'aria-sort="ascending"' : 'aria-sort="descending"'; html = ['<th tabIndex="-1" role="', waiPrefix, 'columnheader"', sortInfo];
}else{
html = ['<td tabIndex="-1" role="', waiPrefix, 'gridcell"'];
}
And later when you close it you just do:
result.push('</td>'); return result; Array
That's incorrect markup, and it in fact shows up in the IE DOM as wrong when using the DOM explorer.
It should be:
if(isHeader){
result.push('</th>');
}else{
result.push('</td>');
}
Attachments (1)
Change History (5)
Changed 13 years ago by
| Attachment: | headerClosure.patch added |
|---|
comment:1 Changed 13 years ago by
| Summary: | Grid incorrectly closes <th> cells when creating header. → [PATCH][CCLA] Grid incorrectly closes <th> cells when creating header. |
|---|
comment:2 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:3 Changed 13 years ago by
| Milestone: | tbd → 1.3 |
|---|
Patch for header closure problem.