[PATCH][CCLA] Grid incorrectly closes <th> cells when creating header.

[Jared Jurkiewicz]

Grid incorrectly closes <th> cells when creating header.

I was actually investigating another bug when I uncovered this one.

In dojox/grid/_Builder.js:

Function: generateCellMarkup:

At the start of the function, you have the following check:

if(isHeader){

var sortInfo = inCell.index != inCell.grid.getSortIndex() ? "" : inCell.grid.sortInfo > 0 ? 'aria-sort="ascending"' : 'aria-sort="descending"'; html = ['<th tabIndex="-1" role="', waiPrefix, 'columnheader"', sortInfo];

}else{

html = ['<td tabIndex="-1" role="', waiPrefix, 'gridcell"'];

}

And later when you close it you just do:

result.push('</td>'); return result; Array

That's incorrect markup, and it in fact shows up in the IE DOM as wrong when using the DOM explorer.

It should be:

if(isHeader){

result.push('</th>');

}else{

result.push('</td>');

}

[Jared Jurkiewicz]

Patch for header closure problem.

[Jared Jurkiewicz]

(In [16983]) Fixing header closure. \!strict fixes #8844

[Jared Jurkiewicz]

(In [16984]) Fixing header closure in less code. \!strict fixes #8844