Opened 10 years ago

Closed 7 years ago

#8840 closed defect (invalid)

[patch][cla] dojox.dtl: in IE, tabIndex parsing error

Reported by: liucougar Owned by: liucougar
Priority: low Milestone: future
Component: DojoX DTL Version: 1.3.0b2
Keywords: Cc:
Blocked By: Blocking:

Description

will commit a change to dojox.dtl test to show that tabIndex in template can not be properly parsed in IE, while tabindex does work

Change History (9)

comment:1 Changed 10 years ago by liucougar

(In [16973]) refs #8840: test case for this ticket in IE, test_tabIndex breaks, while the other one works

comment:2 Changed 10 years ago by liucougar

proposed patch:

Index: dom.js
===================================================================
--- dom.js      (revision 16783)
+++ dom.js      (working copy)
@@ -240,7 +240,7 @@
                                                key = "style";
                                        }else if(dd.BOOLS[key.slice(1)] && dojo.trim(value)){
                                                key = key.slice(1);
-                                       }else if(this._uppers[key] && dojo.trim(value)){
+                                       }else if(this._uppers[key] && (!isNaN(value) || dojo.trim(value))){
                                                clear = this._uppers[key]; // Replaced by lowercase
                                        }
                                }

comment:3 Changed 10 years ago by bill

Milestone: tbd1.4

1.3rc1 has been release; bumping remaining tickets to 1.4 (except for documentation/testing tickets)

comment:4 Changed 10 years ago by Neil Roberts

Status: newassigned

comment:5 Changed 10 years ago by dante

Milestone: 1.41.5
Summary: dojox.dtl: in IE, tabIndex parsing error[patch][cla] dojox.dtl: in IE, tabIndex parsing error

comment:6 Changed 9 years ago by bill

Milestone: 1.51.6

1.5 is released, moving remaining tickets to 1.6

comment:7 Changed 8 years ago by bill

Milestone: 1.6future

(sadly) punting seemingly abandoned ticket and meta tickets to future

comment:8 Changed 8 years ago by ben hockey

Owner: changed from Neil Roberts to liucougar
Priority: highlow
Status: assignedpending

liucougar, is this still a problem? do you want to apply your patch since it seems dtl doesn't have an owner?

comment:9 Changed 7 years ago by trac-o-bot

Resolution: invalid
Status: pendingclosed

Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!

Note: See TracTickets for help on using tickets.