Opened 10 years ago

Closed 10 years ago

#8831 closed enhancement (fixed)

dijit.layout.ContentPane requires dijit._Container unnecessarily

Reported by: ben hockey Owned by: bill
Priority: high Milestone: 1.3
Component: Dijit Version: 1.3.0b2
Keywords: Cc:
Blocked By: Blocking:

Description

as far as i can tell, dijit.layout.ContentPane? does not need dijit._Container any more.

also, (and maybe this should be a separate ticket) having dijit.layout.ContentPane? extend dijit._Container made it really convenient to do widget.placeAt(contentPane); but now that it doesn't extend dijit._Container (although it officially never did) it would be convenient to have an addChild method in dijit.layout.ContentPane? that would make it possible to use placeAt. the ContentPane? doesn't seem to provide a way to add content to it - content can be set/replaced but not added afaik. is this intentional? am i trying to abuse the ContentPane? by adding content to it? or am i missing something?

Change History (2)

comment:1 Changed 10 years ago by bill

Milestone: tbd1.3
Owner: set to bill
Status: newassigned

Ah, you are right about the spurious dojo.require(), although _Container.js is going to get pulled in anyway, indirectly through the dojo.require("dijit.layout._LayoutWidget").

As for addChild() method, I'm conflicted about it, as the meaning is very strange when the ContentPane already contains rich content, but anyway that's filed under a separate ticket #7819.

comment:2 Changed 10 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [16962]) dojo.require("dijit._Container") no longer needed after [16904]. refs #7819, fixes #8831 !strict

Note: See TracTickets for help on using tickets.