[patch] Opera: resizing fails in test_SplitContainer.html

[[email protected]…]

tests/widget/test_SplitContainer.html

Drag separators and nothing happens

[anonymous]

SplitContainer?.beginSizing() is using layerX and layerY properties of the mousedown event which are not supported in Opera (​http://www.quirksmode.org/dom/w3c_events.html#mousepos).

[anonymous]

My suggestion is to fix in event.browser.fixEvent(), since there is already code to do the same for IE. Or just fix it in SplitContainer the same way. Suggested patch follows:

[email protected]:~/devel/ajax/dojo$ svn diff src/event/browser.js
Index: src/event/browser.js
===================================================================
--- src/event/browser.js        (revision 4242)
+++ src/event/browser.js        (working copy)
@@ -230,11 +230,12 @@
                        }
                }

+               if(!evt.layerX && evt.offsetX) { evt.layerX = evt.offsetX; }
+               if(!evt.layerY && evt.offsetY) { evt.layerY = evt.offsetY; }
+
                if(dojo.render.html.ie){
                        if(!evt.target){ evt.target = evt.srcElement; }
                        if(!evt.currentTarget){ evt.currentTarget = (sender ? sender : evt.srcElement); }
-                       if(!evt.layerX){ evt.layerX = evt.offsetX; }
-                       if(!evt.layerY){ evt.layerY = evt.offsetY; }
                        // FIXME: scroll position query is duped from dojo.html to avoid dependency on that entire module
                        if(!evt.pageX){ evt.pageX = evt.clientX + (window.pageXOffset || document.documentElement.scrollLeft || document.body.scrollLeft || 0) }
                        if(!evt.pageY){ evt.pageY = evt.clientY + (window.pageYOffset || document.documentElement.scrollTop || document.body.scrollTop || 0) }
[email protected]:~/devel/ajax/dojo$

[[email protected]…]

Unfortunately, this makes things much worse on Opera. With this change, the layout is completely messed up. The sliders are all the way up and to the left respectively in the two boxes, overlaying each other and still unable to be dragged.

[[email protected]…]

Adam,

Clear cookies and that problem will go away. That container uses cookies to save slider position, but the cookies end up with bogus values and screw things up thereafter.

I don't suggest that fix is pixel perfect though. It looked to me like it offsetX matches layerX 1 to 1 only as long as the element has no padding/margins. Some adjustment probably needs to happen otherwise, but I don't have time (or interest) to delve in that deep at the moment.

Cheers, Stephen

[[email protected]…]

Thanks, Stephen. Much better!

[dylan]

has a patch, bumping to 0.4 as this should be an easy merge

[[email protected]…]

This is fixed by the patch included for #173.

[bill]

(In [5631]) Fixes #173 - just clicking a splitter makes it move 1px Fixes #391 - splitContainer panels sometimes have undesired scrollbars Fixes #883 - opera: resizing fails in test_SplitContainer.html

Patch from Doug (IBM, CCLA on file)

Also, I changed activeResize to be true/false rather than 0/1. Because we're not programming in C anymore. :-)

[(none)]

Milestone 0.4 deleted