Opened 11 years ago

Closed 11 years ago

#8822 closed defect (fixed)

[patch][cla]Dialog: popups loaded by code in a dialog do not handle keypresses

Reported by: Nathan Toone Owned by: Nathan Toone
Priority: low Milestone: 1.4
Component: Dijit Version: 1.3.0b2
Keywords: Cc:
Blocked By: Blocking:

Description

Since dialog makes all other widgets modal, it causes problems when you launch a popup (such as a tooltip dialog) that has additional widgets - they do not respond to keypresses.

The solution is as we are checking in our dialog's _onKey function, we should also see if the dom we are in has a dijitPopup class - meaning that it is within a popup.

This may not work in all cases - but seems to be fairly workable.

Attachments (1)

8822.patch (442 bytes) - added by Nathan Toone 11 years ago.
Patch which addresses this issue

Download all attachments as: .zip

Change History (5)

Changed 11 years ago by Nathan Toone

Attachment: 8822.patch added

Patch which addresses this issue

comment:1 Changed 11 years ago by bill

Milestone: future1.4
Summary: Popups loaded by code in a dialog do not handle keypressesDialog: popups loaded by code in a dialog do not handle keypresses

Agreed... this is a problem that needs to be fixed. It's similar to #7716 and might be fixed at the same time.

This looks like a good quick fix to the problem; not sure if it handles all cases, or also if there's ever a problem where this code will trigger for a popup node behind the Dialog (hidden by the underlay), but should work in general at least.

comment:2 Changed 11 years ago by Nathan Toone

Summary: Dialog: popups loaded by code in a dialog do not handle keypresses[patch][cla]Dialog: popups loaded by code in a dialog do not handle keypresses

comment:3 Changed 11 years ago by Nathan Toone

Milestone: 1.41.3.1

Fixed on trunk in [17153] - changing to 1.3.1 for consideration for inclusion in branch.

comment:4 Changed 11 years ago by Nathan Toone

Milestone: 1.3.11.4
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.