Opened 11 years ago

Closed 11 years ago

#8820 closed enhancement (fixed)

[patch][cla]dijit._Widget can be sped up a bit by using dojo._connect instead of dojo.connect

Reported by: Nathan Toone Owned by: Nathan Toone
Priority: lowest Milestone: 1.4
Component: Dijit Version: 1.3.0b2
Keywords: Cc:
Blocked By: Blocking:

Description

However, this apparently (as-is) breaks some key events on widgets (see #8816 ) - I'm just logging this issue for myself to look at later, if it's really a big deal (which I'm not sure it is or not).

Attachments (1)

8820.patch (672 bytes) - added by Nathan Toone 11 years ago.
This patch puts the _connect back in - and fixes the connect so that key press events work on widgets

Download all attachments as: .zip

Change History (6)

comment:1 Changed 11 years ago by 7twenty

FYI, we can keep the performance fix and fix the onKeyPress issue by changing _Widget.js (line 7) from:

dojo.connect(dojo, "connect",

to:

dojo.connect(dojo, "_connect", 

dojox/robot/recorder.js is also listening to all dojo.connects, so that might need to be updated.

Changed 11 years ago by Nathan Toone

Attachment: 8820.patch added

This patch puts the _connect back in - and fixes the connect so that key press events work on widgets

comment:2 Changed 11 years ago by bill

Ah yes, that's the problem. I recently checked in a test_deferredConnects.html will also come in handy to confirm that this keeps working. It's part of the automated tests for dijit.

comment:3 Changed 11 years ago by Nathan Toone

Milestone: future1.4
Summary: dijit._Widget can be sped up a bit by using dojo._connect instead of dojo.connect[patch][cla]dijit._Widget can be sped up a bit by using dojo._connect instead of dojo.connect

comment:4 Changed 11 years ago by Nathan Toone

Milestone: 1.41.3.1

Fixed in trunk in [17154] - changing milestone for consideration for inclusion on branch

comment:5 Changed 11 years ago by Nathan Toone

Milestone: 1.3.11.4
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.