Opened 11 years ago

Closed 11 years ago

Last modified 9 years ago

#8818 closed defect (fixed)

RadioButton Still Shares Require With CheckBox

Reported by: Feneric Owned by: bill
Priority: high Milestone: 1.3
Component: Dijit - Form Version: 1.3.0b2
Keywords: dijit.form.RadioButton, dijit.form.CheckBox Cc:
Blocked By: Blocking:

Description

"Previously multiple dijit widgets were included in the same file/module, so for example you would do dojo.require("dijit.form.Button") to use dijit.form.ComboButton?. That's still supported for backwards-compatibility reasons, it will be removed in 2.0, and starting now you should have a separate dojo.require() call for each widget you are using."

RadioButton? seems to have gotten overlooked when widgets were being separated out into their own files. Right now one still has to dojo.require("dijit.form.CheckBox?") in order to get dijit.form.RadioButton?.

Change History (5)

comment:1 Changed 11 years ago by bill

Milestone: tbd1.3
Owner: set to bill
Status: newassigned

Ah, you are right...

Well, we can't actually split the RadioButton code to a separate file until 2.0, because it would create a circular dependency, since RadioButton extends CheckBox, yet for backwards compatibility doing a dojo.require() of CheckBox.js needs to define RadioButton. That's filed under #8366.

However, we can and should create the stub file where RadioButton points to ComboBox.

comment:2 Changed 11 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [16931]) RadioButton? stub file was forgotten in [15592]. Refs #8017, fixes #8818.

comment:3 in reply to:  2 Changed 11 years ago by sayuri

Resolution: fixed
Status: closedreopened

dojo.requie() still failed. Rename dijit/form/RadioButton.html to dijit/form/RadioButton.js.

comment:4 Changed 11 years ago by bill

Resolution: fixed
Status: reopenedclosed

(In [16959]) Oops, misnamed the file. This time really fixes #8818 I think (and refs #8017).

comment:5 Changed 9 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.