Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#8816 closed defect (fixed)

Widget key events broken after #8764

Reported by: Mark Wubben Owned by: Nathan Toone
Priority: high Milestone: 1.3
Component: Dijit Version: 1.3.0b2
Keywords: Cc: Nathan Toone
Blocked By: Blocking:

Description

r16901 breaks key events for widgets. I've tried with dijit.form.TextBox? and dijit.form.Textarea.

The problem seems to be in the use of dojo._connect rather than dojo.connect in line 878, although I can't figure out why. Switching to dojo.connect solves the problem.

Change History (4)

comment:1 Changed 11 years ago by bill

Milestone: tbd1.3
Owner: set to Nathan Toone

I'm not sure I understand how to reproduce this problem?

comment:2 Changed 11 years ago by Mark Wubben

Sorry, if I attach to onKeyPress on a TextBox?, the event never fires.

comment:3 Changed 11 years ago by Nathan Toone

Resolution: fixed
Status: newclosed

(In [16933]) Fixes #8816 - change back to using connect instead of _connect !strict

comment:4 Changed 11 years ago by 7twenty

FYI, we can keep the perfomance fix and fix the onKeyPress issue by changing _Widget.js (line 7) from:

dojo.connect(dojo, "connect",

to:

dojo.connect(dojo, "_connect", 
Note: See TracTickets for help on using tickets.