Opened 10 years ago

Closed 10 years ago

#8815 closed defect (fixed)

ToggleButton has no margin

Reported by: sayuri Owned by: Douglas Hays
Priority: high Milestone: 1.4
Component: Dijit - LnF Version: 1.3.0b2
Keywords: Cc: sayuri
Blocked By: Blocking:

Description

dijit.form.ToggleButton has no margin. But all other buttons have margin at dijit.css.

Should add dijitToggleButton to this style? But I don't know the impact.

Change History (5)

comment:1 Changed 10 years ago by bill

Component: DijitDijit - LnF
Owner: set to Douglas Hays

I think you are right, just looks like an oversight to me.

comment:2 Changed 10 years ago by Douglas Hays

Status: newassigned

comment:3 Changed 10 years ago by Douglas Hays

Milestone: tbdfuture

I think this should be deferred for now since it impacts the Editor toolbar.

comment:4 Changed 10 years ago by bill

Milestone: future1.4

There's another rule in dijit.css that needs to be updated to include ToggleButton too, which solves the editor issue:

.dijitToolbar .dijitButton,
.dijitToolbar .dijitDropDownButton,
.dijitToolbar .dijitComboButton {
	margin: 0;
}

Not sure if there's anywhere else the we left off ToggleButton, I guess we need to check through the theme files too.

Anyway, this seems pretty low risk, how about for 1.4?

comment:5 Changed 10 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

(In [17337]) Fixes #8815. Add missing dijitToggleButton rules to dijit.css

Note: See TracTickets for help on using tickets.