Opened 13 years ago
Closed 13 years ago
#8815 closed defect (fixed)
ToggleButton has no margin
Reported by: | sayuri | Owned by: | Douglas Hays |
---|---|---|---|
Priority: | high | Milestone: | 1.4 |
Component: | Dijit - LnF | Version: | 1.3.0b2 |
Keywords: | Cc: | sayuri | |
Blocked By: | Blocking: |
Description
dijit.form.ToggleButton has no margin. But all other buttons have margin at dijit.css.
Should add dijitToggleButton to this style? But I don't know the impact.
Change History (5)
comment:1 Changed 13 years ago by
Component: | Dijit → Dijit - LnF |
---|---|
Owner: | set to Douglas Hays |
comment:2 Changed 13 years ago by
Status: | new → assigned |
---|
comment:3 Changed 13 years ago by
Milestone: | tbd → future |
---|
I think this should be deferred for now since it impacts the Editor toolbar.
comment:4 Changed 13 years ago by
Milestone: | future → 1.4 |
---|
There's another rule in dijit.css that needs to be updated to include ToggleButton too, which solves the editor issue:
.dijitToolbar .dijitButton, .dijitToolbar .dijitDropDownButton, .dijitToolbar .dijitComboButton { margin: 0; }
Not sure if there's anywhere else the we left off ToggleButton, I guess we need to check through the theme files too.
Anyway, this seems pretty low risk, how about for 1.4?
comment:5 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
I think you are right, just looks like an oversight to me.