Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#8811 closed defect (fixed)

[PATCH][CCLA]: IE Specific: Selecting blank area of a grid and hitting arrow key to nav throws error

Reported by: Jared Jurkiewicz Owned by: Bryan Forbes
Priority: high Milestone: 1.3
Component: DojoX Grid Version: 1.3.0b2
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Jared Jurkiewicz)

This is visible with current test files: dojox/grid/tests/test_data_grid_empty.html

Click in the blank area under the header.

Hit an arrow key

IE throws error: this.cell.index is null or not an object

Doesn't occur on other browsers.

Attachments (1)

_FocusManager.patch (3.8 KB) - added by Jared Jurkiewicz 10 years ago.
Tentative patch that adds in checks on this.cell before it is used in several functions.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 10 years ago by Jared Jurkiewicz

Description: modified (diff)

Changed 10 years ago by Jared Jurkiewicz

Attachment: _FocusManager.patch added

Tentative patch that adds in checks on this.cell before it is used in several functions.

comment:2 Changed 10 years ago by Jared Jurkiewicz

Summary: IE Specific: Selecting blank area of a grid and hitting arrow key to nav throws error[PATCH][CCLA]: IE Specific: Selecting blank area of a grid and hitting arrow key to nav throws error

Added a patch that just wraps several places in _FocusManager with a check on this.cell before it tries to make use of it. This avoids the error seen in IE when the grid has focus but no cell was selected, then an arrow key is hit. The grid simply doesn't try to do anything now (no cell selected).

Let me know if this is good enough and I'll commit it.

comment:3 Changed 10 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

comment:4 Changed 10 years ago by Adam Peller

Milestone: tbd1.3

batch move of tickets marked 'tbd' fixed in the 1.3 timeframe

Note: See TracTickets for help on using tickets.