Opened 11 years ago
Closed 11 years ago
#8798 closed defect (fixed)
Check for global scope violations for Dojo 1.3 Release
Reported by: | dylan | Owned by: | dylan |
---|---|---|---|
Priority: | high | Milestone: | 1.3 |
Component: | General | Version: | 1.3.0b2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Check for global scope violations for the 1.3 release.
Change History (12)
comment:1 Changed 11 years ago by
comment:2 Changed 11 years ago by
NodeList?.js, line 481:
return d.query(queryOrListOrNode).place(item[0], position); // dojo.NodeList
item is out of scope.
comment:4 Changed 11 years ago by
(In [16891]) refs #8798, add fixme note to TablePlugin? for the editor, and fix another global scope issue, \!strict
comment:7 Changed 11 years ago by
comment:8 Changed 11 years ago by
In layout/dnd/PlottedDnd.js, the following are unexplained global vars. They either need to be fixed or documented:
IEonselectstart autoScrollActive
comment:9 Changed 11 years ago by
Ok, once the two comments are addressed in this bug, this one is done.
comment:10 Changed 11 years ago by
comment:11 Changed 11 years ago by
(In [16992]) refs #8798 - global refs (half) in PlottedDnd?.js - autoScrollActive -> this.autoScrollActive ... A little concerned about the IOonselectstart fix there. It stores a ref to the orig handler and restores it on dnd-stop/cancel. Could just wrap it in cl oseure, but wondering if IE will leak here by doing so. !strict
comment:12 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
(In [16889]) refs #8798, declare a variable that was scoped globally in Dijit's scroll.js, \!strict