Opened 11 years ago

Closed 11 years ago

#8787 closed enhancement (fixed)

AccordionContainer no onHide function called on children

Reported by: jfcunat Owned by: Adam Peller
Priority: high Milestone: 1.3
Component: Dijit Version: 1.3.0b2
Keywords: Cc: emorvillez.ext@…
Blocked By: Blocking:

Description

When you change of pane in a AccordionContainer?, there is a call to show the new child but no call to hide the old one.

In the overriden function _transition of the AccordionContainer?, only the _showChild is called (and the onShow method on the child if it exists). The _hideChild is not called (and not the onHide of the child). Is there any reason ? In the ancestor this method _hideChild is called.

We rely on this method to deactivate some features of our components when they are hidden in a layout widget.

I give a patch to add the call in the OnEnd? of the animation of onHide if the widget has this function

Attachments (1)

AccordionContainer.patch (646 bytes) - added by jfcunat 11 years ago.

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by jfcunat

Attachment: AccordionContainer.patch added

comment:1 Changed 11 years ago by Adam Peller

Owner: set to Adam Peller

comment:2 Changed 11 years ago by Adam Peller

Resolution: fixed
Status: newclosed

(In [16875]) Fixes overlapping accordion transitions, call onHide. Thanks jfcunat for the great patch! Fixes #8788, #8787.

Note: See TracTickets for help on using tickets.