Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#8781 closed enhancement (fixed)

[dojox.image] LightboxNano can be reduced some

Reported by: dante Owned by: cb1kenobi
Priority: low Milestone: 1.3
Component: Dojox Version: 1.3.0b2
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by dante)

None of the _private members that are null need to exist in the declare call if you are only checking truthyness or populating it as part of the buildup. they can remain inline for comments but stripped from a build if you wrap them in the doc syntax:

/*=====
    // member: String
    //   blal blah
    member: null
=====*/

}}}}

this will make the overall size smaller. Also, in 1.3/trunk there is dojo.create which could be utilized in some places you are using dojo.doc.createElement.

Change History (6)

comment:1 Changed 11 years ago by dante

Description: modified (diff)

comment:2 Changed 11 years ago by bill

Component: GeneralDojox

comment:3 Changed 11 years ago by cb1kenobi

(In [16921]) Updated the code to use dojo.create() and reduced a lot of code. Implemented new getViewport() function. Removed unnecessary _private variables. Refs #8781.

comment:4 Changed 11 years ago by cb1kenobi

Owner: changed from cb1kinobi to cb1kenobi
Status: newassigned

Finished clean up and was able to reduce size before a build from 8,673 to 6,936 bytes, after build from 4,174 to 3,495 bytes, and after build+gzip from 1,818 to 1,599 bytes.

comment:5 Changed 11 years ago by cb1kenobi

Resolution: fixed
Status: assignedclosed

comment:6 Changed 11 years ago by Adam Peller

Milestone: future1.3

batch move of tickets marked 'future' in the 1.3 timeframe

Note: See TracTickets for help on using tickets.