[PATCH] [CCLA] Problem with horizontal scroll with empty grid, long header.

[Jared Jurkiewicz]

Reported by a co-worker of mine:

See attached horizontal_scroll_problem.html for a recreate of this problem. Initially there is one item in the grid and the horizontal scroll bar can be used to scroll to all three columns. When you click the Delete Item button the item is deleted so the grid is empty. The horizontal scroll bar no longer shows up so you can't see the last column in the grid. The problem is that we have certain functionality built into our grid where the user might need to see the column header even if there is no data in the grid. The horizontal scroll bar is needed in this case to see the Population column even if there is no data.

[Jared Jurkiewicz]

Reproducible as well on 1.3

[Jared Jurkiewicz]

Basic patch for this from talking with Bryan Forbes. Makes sure that an empty content view still gets a height of 1px so the scroller will show. Without this, an empty grid can't be scrolled to even see the header.

[Jared Jurkiewicz]

Feedback from a co-worker on this (they have an app using Grid with 2 views), and it seems to work great for them. They get the scroller eiven for an empty dataset and can scroll-view the header fine.

[Jared Jurkiewicz]

Found a problem with the patch. Calling _refresh() without true causes it to just set the height to 1, hiding all the data in the grid. Argh. Working on a fix/catch for that.

[Jared Jurkiewicz]

Fix turns out to be simple, just move the oldPageCount check up a few lines and _refresh() works fine.

[Jared Jurkiewicz]

Tweaked version of the patch that works better.

[Jared Jurkiewicz]

(In [16942]) Fix for horizontal scollbar vanishing. \!strict fixes #8774

[Adam Peller]

batch move of tickets marked 'tbd' fixed in the 1.3 timeframe