Opened 14 years ago
Closed 14 years ago
#877 closed defect (invalid)
nasty bug in getOuterHeight() and related functions
| Reported by: | Owned by: | anonymous | |
|---|---|---|---|
| Priority: | high | Milestone: | |
| Component: | General | Version: | 0.3 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
This could be condiered a bug in AccordionPane? instead. AccordionPane? defines a method called getCollpasedHeight() which is supposed to return the heigh of the label. However, if the widget has currently got a display of none, the height always shows as 0 because getCollapsedHeight() calls dojo.style.getOuterHeight() which calls dojo.style.getInnerHeight() which uses node.offsetHeight which is always 0 when display is set to none.
The call in AccordionPane?.getCollapsedHeight() really should return the height of the labelNode regardless of its state of display. Perhaps getOuterHeight() is intentionally returning 0 when the node isn't displayed, in which case it is a bug in Accordion, but it is a problem, nonetheless
Change History (2)
comment:1 Changed 14 years ago by
comment:2 Changed 14 years ago by
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
This was actually an issue with Safari returning an empty string for the height of the node, which was then failing to be parsed by getPixelValue() which was then not returning NaN because it wasn't checking for NaN, since it always expected at least a 0px string, I guess. I filed another bug with a patch