Opened 12 years ago

Last modified 11 years ago

#8764 closed enhancement

_Widget.connect performance is horrible — at Initial Version

Reported by: Nathan Toone Owned by:
Priority: high Milestone: 1.3
Component: Dijit Version: 1.3.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

The connect uses an extra dojo.hitch in all cases - when it really isn't necessary. This really hurts performance, and in IE it is extremely poor.

A patch follows. Timings on my machine (prior to patching in parenthesis): IE8 100 "onblur" connects - 16ms (31ms) IE8 100 "ondijitclick" connects - 63ms (63ms) IE8 all 200 disconnects - 16ms (16ms) FF3 100 "onblur" connects - 13ms (20ms) FF3 100 "ondijitclick" connects - 69ms (65ms) FF3 all 200 disconnects - 20ms (17ms)

This yields nearly 50% improvement for the common case of non-'ondijitclick' connections. The "ondijitclick" function could probably be further refactored for better performance as well.

Change History (1)

Changed 12 years ago by Nathan Toone

Patch and test case for _Widget.connect performance improvement

Note: See TracTickets for help on using tickets.