Changes between Initial Version and Version 1 of Ticket #8764


Ignore:
Timestamp:
Feb 27, 2009, 3:56:41 AM (10 years ago)
Author:
bill
Comment:

Hmm, thanks for the patch/tests.... I agree that the dojo.hitch() is unneeded. Looks like someone was overzealous in byte shaving.

Although it does look like the patch is adding a lot of branching for ondijitclick vs onclick (changing the return type so you have to test if(dojo.isArray(c))), that might hurt us more than helping us, as it's increasing the code size.

In any case let's add this for 1.4.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #8764

    • Property Owner set to Nathan Toone
    • Property Milestone changed from tbd to 1.4
  • Ticket #8764 – Description

    initial v1  
    22
    33A patch follows.  Timings on my machine (prior to patching in parenthesis):
     4{{{
    45IE8 100 "onblur" connects - 16ms (31ms)
    56IE8 100 "ondijitclick" connects - 63ms (63ms)
     
    89FF3 100 "ondijitclick" connects - 69ms (65ms)
    910FF3 all 200 disconnects - 20ms (17ms)
     11}}}
    1012
    1113This yields nearly 50% improvement for the common case of non-'ondijitclick' connections.  The "ondijitclick" function could probably be further refactored for better performance as well.