Opened 11 years ago

Closed 11 years ago

#8706 closed defect (fixed)

[patch][cla] ExpandoPane should add position-aware classes when closed

Reported by: Shane O'Sullivan Owned by: dante
Priority: high Milestone: 1.4
Component: Dojox Version: 1.3.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

Currently when the Expando pane closes, it adds the class dojoxExpandoClosed to the root node.

This does not enable it to choose the collapsed icon for the closed state depending on if it is at the top, bottom, left or right.

It should also add dojoxExpandoClosed-{position}, e.g. dojoExpandoClosed-Top

Attachments (2)

Expando_ClosedStyle.patch (1.0 KB) - added by Shane O'Sullivan 11 years ago.
Patch to fix this issue
Expando_ClosedStyle2.patch (3.7 KB) - added by Shane O'Sullivan 11 years ago.
Updated patch to fix this issue

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by Shane O'Sullivan

Attachment: Expando_ClosedStyle.patch added

Patch to fix this issue

comment:1 Changed 11 years ago by Adam Peller

Owner: changed from Adam Peller to dante

comment:2 Changed 11 years ago by dante

Milestone: 1.31.4
Status: newassigned
Summary: ExpandoPane should add position-aware classes when closed[patch][cla] ExpandoPane should add position-aware classes when closed

I don't feel like this change safely addresses all the CSS changes that need to be made to accommodate the various open/closed states. it just changes the class used.

comment:3 Changed 11 years ago by Shane O'Sullivan

What other changes do you see as necessary? Would they not also contain the changes suggested in this ticket? If so, could these changes not be applied, giving you the ability to specify the correct icons in the closed state, and additional enhancements be made for 1.4?

Shane

comment:4 Changed 11 years ago by dante

I am just saying the patch wasn't thought through, and is incomplete.

	/* hide all layout children scrollbars when closed */
	.dojoxExpandoClosed .dojoxExpandoWrapper * {
		overflow:hidden !important;
	}

that needs changed.

	.dojoxExpandoClosed .dojoxExpandoIcon {
		background-position: 0px 0px;
		margin:0 auto;
	}

there too. also:

	.soria .dojoxExpandoClosed .dojoxExpandoTitle {
	.soria .dojoxExpandoClosed {
	.soria .dojoxExpandoClosed .dojoxExpandoIcon {
	.tundra .dojoxExpandoClosed .dojoxExpandoTitle {
	.tundra .dojoxExpandoClosed {
	.tundra .dojoxExpandoClosed .dojoxExpandoTitle,
	.tundra .dojoxExpandoClosed {
		background-color: #fafafa;
	.tundra .dojoxExpandoClosed .dojoxExpandoIcon {
	.nihilo .dojoxExpandoClosed .dojoxExpandoTitle {

it actually keeps going. All from resources/ExpandoPane.css ... you patch makes dojoxExpandoClosed class unused, this all those rules either wrong or waste.

This patch is not complete.

Changed 11 years ago by Shane O'Sullivan

Attachment: Expando_ClosedStyle2.patch added

Updated patch to fix this issue

comment:5 Changed 11 years ago by dante

Resolution: fixed
Status: assignedclosed

bummer. [17316]

Note: See TracTickets for help on using tickets.