Opened 12 years ago
Closed 12 years ago
#8703 closed enhancement (fixed)
[dojo._base.fx] default fps is too high
Reported by: | liucougar | Owned by: | dante |
---|---|---|---|
Priority: | high | Milestone: | 1.4 |
Component: | fx | Version: | 1.3.0b1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
the doc for rate in dojo._base.fx is:
// rate: Integer // the time in milliseconds to wait before advancing to next frame // (used as a fps timer: rate/1000 = fps)
I think the fps timer should read "1000/rate = fps" instead
in addition, currently, rate is set to 10, which translates to fps=100, which I think is too much. 30fps is more than enough for human eyes. I think for js animation, 16fps is enough (rate=60).
Change History (4)
comment:1 Changed 12 years ago by
Milestone: | tbd → 1.4 |
---|---|
Summary: | doc typo in dojo._base.fx → [dojo._base.fx] default fps is too high |
comment:2 Changed 12 years ago by
I should also be noted here that while talking with Valerio regarding Moo framerates the suggestion was made:
rate: 10 + (new Date().getYear - 2008)
which is not only future proof, but hilarious.
comment:3 Changed 12 years ago by
Owner: | changed from Bryan Forbes to dante |
---|---|
Status: | new → assigned |
I tested (visually) 16fp (rate:60) and it was way too choppy. 30 was OK, but I think 20 is the best bet. Not visual difference in the smoothness of the animations, and we get up above IEs threshold for latency.
comment:4 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
changed to rate: 20 in [17247]
see: http://lazutkin.com/blog/2008/mar/23/javascript-edp-and-0ms-timeouts/ eugene's blog on timeout
IE can't do anything smaller than 13. And in jquery they are doing 13 ( http://dev.jquery.com/browser/trunk/jquery/src/fx.js#L300 ). Mootool is doing 20 (50fps).
too deep into 1.3 release cycle, punt until later