#8697 closed defect (fixed)
prototype and dojo conflict in dojo.query
| Reported by: | ttilley | Owned by: | alex |
|---|---|---|---|
| Priority: | high | Milestone: | 1.3 |
| Component: | Query | Version: | 1.3.0b1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description (last modified by )
Being the not-even-close-to-good-citizen prototype is, it extends document with getElementsByClassName, which dojo.query tests for to see if it can use a fast path. Of course, this fails horribly when using IE7 with prototype and dojo in the same page.
The following check does the right thing, even with prototype extending document:
(document.getElementsByClassName && /\{\s*\[native code\]\s*\}/.test(String(document.getElementsByClassName)))
Attachments (1)
Change History (8)
Changed 11 years ago by
| Attachment: | dojo-prototype-query-workaround.diff added |
|---|
comment:1 Changed 11 years ago by
slightlyoff wanted this assigned to him:
slightlyoff: want to make sure we can add a regex test and that it'll be fast enough slightlyoff: ok, they get cached slightlyoff: +1 slightlyoff: Aphelion: post a bug report and a patch? slightlyoff: ('cause I can't check this fix in w/o a bug anyway)
comment:2 Changed 11 years ago by
| Milestone: | 1.3 → tbd |
|---|---|
| Owner: | changed from anonymous to alex |
| severity: | critical → normal |
comment:3 Changed 11 years ago by
| Priority: | normal → high |
|---|---|
| severity: | normal → major |
| Status: | new → assigned |
comment:4 Changed 11 years ago by
| Description: | modified (diff) |
|---|
comment:5 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:6 Changed 11 years ago by
| Milestone: | tbd → 1.3 |
|---|
batch move of tickets marked 'tbd' fixed in the 1.3 timeframe
comment:7 Changed 11 years ago by
| Component: | Core → Query |
|---|
Note: See
TracTickets for help on using
tickets.
dojo.query workaround for using dojo with prototype