Opened 10 years ago

Closed 10 years ago

#8690 closed task (fixed)

Tree: move dijit._tree files to dijit.tree

Reported by: bill Owned by: bill
Priority: high Milestone: 1.4
Component: Dijit Version: 1.3.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

dijit._tree.dndSelector is publicly used and should be in dijit/tree, not dijit/_tree.

Of course, need to leave a stub in dijit._tree, to be removed in 2.0.

Should probably also move dndContainer.js and dndSelector.js, but since those are only used by dndSelector, should rename them to _dndSelector and _dndContainer.

Change History (6)

comment:1 Changed 10 years ago by bill

Should also remove all the dead code in those files, we I am currently marking as "TODO" items in the comments (but won't actually do until after 1.3 ships)

comment:2 Changed 10 years ago by bill

Oh, and change all the private/protected methods to have underscores.

comment:3 Changed 10 years ago by bill

Resolution: fixed
Status: newclosed

(In [17392]) Put dndSource in dijit.tree, not dijit._tree, since it's used publicly. Fixes #8690 !strict.

comment:4 Changed 10 years ago by sayuri

Resolution: fixed
Status: closedreopened

At r17392, _dndContainer.js and _dndSelector.js were moved. But dndSource.js was copied, so it still exists. I think dndSource.js and dijit/_tree should be removed.

comment:5 in reply to:  4 Changed 10 years ago by sayuri

Replying to sayuri:

At r17392, _dndContainer.js and _dndSelector.js were moved. But dndSource.js was copied, so it still exists. I think dndSource.js and dijit/_tree should be removed.

I'm sorry...

comment:6 Changed 10 years ago by bill

Resolution: fixed
Status: reopenedclosed

I can't just remove dijit/_tree/dndSource.js because it will break existing applications. So I left it there as a deprecated copy. It just points to the file in dijit/tree.

Note: See TracTickets for help on using tickets.