Opened 10 years ago
Closed 10 years ago
#8690 closed task (fixed)
Tree: move dijit._tree files to dijit.tree
| Reported by: | bill | Owned by: | bill |
|---|---|---|---|
| Priority: | high | Milestone: | 1.4 |
| Component: | Dijit | Version: | 1.3.0b1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
dijit._tree.dndSelector is publicly used and should be in dijit/tree, not dijit/_tree.
Of course, need to leave a stub in dijit._tree, to be removed in 2.0.
Should probably also move dndContainer.js and dndSelector.js, but since those are only used by dndSelector, should rename them to _dndSelector and _dndContainer.
Change History (6)
comment:1 Changed 10 years ago by
comment:2 Changed 10 years ago by
Oh, and change all the private/protected methods to have underscores.
comment:3 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:4 follow-up: 5 Changed 10 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
At r17392, _dndContainer.js and _dndSelector.js were moved. But dndSource.js was copied, so it still exists. I think dndSource.js and dijit/_tree should be removed.
comment:5 Changed 10 years ago by
comment:6 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
I can't just remove dijit/_tree/dndSource.js because it will break existing applications. So I left it there as a deprecated copy. It just points to the file in dijit/tree.
Should also remove all the dead code in those files, we I am currently marking as "TODO" items in the comments (but won't actually do until after 1.3 ships)