Opened 11 years ago

Closed 10 years ago

#8669 closed defect (fixed)

buildsystem is broken for non browser environments

Reported by: petschm Owned by: James Burke
Priority: high Milestone: 1.3
Component: BuildSystem Version: 1.3.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

 if(hostenvType == "browser" || isBrowser){ 

isBrowser will never be set and the build script fails.

http://bugs.dojotoolkit.org/browser/tags/release-1.3.0b1/util/buildscripts/jslib/buildUtil.js?rev=16653#L368

Maybe isBrowser should be set in a build profile, but then is must be something like

 if(hostenvType == "browser" || kwArgs.profileProperties["isBrowser"] ){ 

and the function buildUtil.evalProfile ( http://bugs.dojotoolkit.org/browser/tags/release-1.3.0b1/util/buildscripts/jslib/buildUtil.js?rev=16653#L617 ) must be modified to support isBrowser.

see also [15409]

Change History (3)

comment:1 Changed 11 years ago by Adam Peller

Component: GeneralBuildSystem
Owner: changed from anonymous to James Burke

comment:2 Changed 11 years ago by James Burke

Milestone: tbd1.3

comment:3 Changed 10 years ago by James Burke

Resolution: fixed
Status: newclosed

(In [16774]) Fixes #8669, cannot build rhino hostenv builds, and refs #3833, building Dojo for firefox extensions.

Note: See TracTickets for help on using tickets.