Opened 13 years ago
Closed 13 years ago
#8662 closed defect (fixed)
[patch]Dojo 1.3 beta + dojox.Grid + header Menu
Reported by: | Dom Derrien | Owned by: | Bryan Forbes |
---|---|---|---|
Priority: | high | Milestone: | 1.3 |
Component: | DojoX Grid | Version: | 1.3.0b1 |
Keywords: | Cc: | Nathan Toone | |
Blocked By: | Blocking: |
Description (last modified by )
In dojox/grid/_Grid.js, around line 600:
_setHeaderMenuAttr: function(menu){ if(this._placeholders.length){ dojo.forEach(this._placeholders, function(p){ p.unReplace(true); }); this._placeholders = []; } ...
It appears the verification of this._placeholders being not null is missing :( Then the setup of grids which have header menus fails.
I just did a local update with a correct "if" statement and everything seems to work fine... Without this fix, the migration 1.2.3 to 1.3 is not possible for such grids.
_setHeaderMenuAttr: function(menu){ if('''this._placeholders &&''' this._placeholders.length){ dojo.forEach(this._placeholders, function(p){ p.unReplace(true); }); this._placeholders = []; } ...
I hope this helps. A+, Dom
Change History (4)
comment:1 Changed 13 years ago by
Component: | Dijit → DojoX Grid |
---|---|
Owner: | set to Bryan Forbes |
comment:2 Changed 13 years ago by
Description: | modified (diff) |
---|---|
Milestone: | tbd → 1.3 |
Priority: | normal → high |
Summary: | Dojo 1.3 beta + dojox.Grid + header Menu → [patch]Dojo 1.3 beta + dojox.Grid + header Menu |
comment:3 Changed 13 years ago by
Cc: | Nathan Toone added |
---|
comment:4 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
trivial patch, alleged 1.3 compatibility issue