Opened 12 years ago
Closed 8 years ago
#8637 closed defect (duplicate)
[patch]Key Selection Bug in the DataGrid
Reported by: | aizen | Owned by: | Evan |
---|---|---|---|
Priority: | high | Milestone: | 1.5.3 |
Component: | DojoX Grid | Version: | 1.2.3 |
Keywords: | Grid Bug Key Shift | Cc: | |
Blocked By: | Blocking: |
Description
Select with <Shift>+<DOWN Arrow> doesn't work correctly. It selects only two rows when we are moving down in the Grid. But <Shift>+<UP Arrow> works fine. You can reproduce it in this test \dojox\grid\tests\test_grid.html I investigate this issue and found bug in _range method (dojox.grid.Selection). fix is attached:
Attachments (2)
Change History (8)
Changed 12 years ago by
Attachment: | Selection.js added |
---|
comment:1 Changed 12 years ago by
Summary: | Key Selection Bug in the DataGrid → [patch]Key Selection Bug in the DataGrid |
---|
comment:2 Changed 12 years ago by
Milestone: | tbd → future |
---|
comment:3 Changed 9 years ago by
Cc: | evan added |
---|
With this being a trivial patch, is it safe to get committed? The bug still exists today and affects more than just keyboard selection -- (shift+click selection going down a page is broken, but works going up a page)
IE: click row 5 shift+click row 7 shift+click row 9 result: 7-9 selected (not expected)
click row 9 shift+click row 7 shift+click row 5 result: 5-9 selected (as expected)
comment:4 Changed 9 years ago by
Cc: | evan removed |
---|---|
Owner: | changed from Bryan Forbes to Evan |
Status: | new → assigned |
comment:5 Changed 8 years ago by
comment:6 Changed 8 years ago by
Milestone: | future → 1.5.3 |
---|---|
Resolution: | → duplicate |
Status: | assigned → closed |
no cla, but the patch seems trivial.