Opened 11 years ago

Closed 11 years ago

#8633 closed defect (fixed)

scroll test failures on FF3/mac

Reported by: bill Owned by: Douglas Hays
Priority: high Milestone: 1.3
Component: Dijit Version: 1.2.3
Keywords: Cc:
Blocked By: Blocking:

Description

I'm seeing the following failures on FF3/mac when running the scroll tests through tests/runtests.html:

     _AssertFailure: http://localhost/trunk2/dojo/_base/_loader/bootstrap.js:538 doh._AssertFailure: assertEqual() failed:
  expected (-9,-29) but got (-6,-26)
 doh._AssertFailure
     ERROR IN:
  (function test_innerScrollbars_strict() {var minScroll, maxScroll;if (dojo.isIE <= 6) {minScroll = "(+32,+11)";maxScroll = "(-32,+21)";} else if (dojo.isIE == 7) {minScroll = "(+31,+10)";maxScroll = "(-31,+21)";} else if (dojo.isIE) {minScroll = "(-20,+25)";maxScroll = "(-9,-29)";} else if (dojo.isFF < 3) {minScroll = "(-20,+25)";maxScroll = "(-10,-32)";} else if (dojo.isFF) {minScroll = "(-20,+27)";maxScroll = "(-9,-29)";} else if (dojo.isWebKit) {minScroll = "(-20,+9)";maxScroll = "(-7,+22)";}generateTest("innerScrollbars_strict", maxScroll, minScroll);})
 FAILED test: ../../dijit/tests/_base/test_scroll.html::dijit._base.scroll::test_innerScrollbars_strict 70 ms
     _AssertFailure: http://localhost/trunk2/dojo/_base/_loader/bootstrap.js:538 doh._AssertFailure: assertEqual() failed:
  expected (-9,+22) but got (-6,+22)
 doh._AssertFailure
     ERROR IN:
  (function test_innerScrollbars_none() {var minScroll, maxScroll;if (dojo.isIE <= 6) {minScroll = "(+40,+19)";maxScroll = "(-40,+21)";} else if (dojo.isIE == 7) {minScroll = "(+39,+18)";maxScroll = "(-39,+21)";} else if (dojo.isIE) {minScroll = "(+39,+18)";maxScroll = "(-39,+21)";} else if (dojo.isFF < 3) {minScroll = "(-20,+12)";maxScroll = "(-10,+22)";} else if (dojo.isFF) {minScroll = "(-20,+11)";maxScroll = "(-9,+22)";} else if (dojo.isWebKit) {minScroll = "(-20,+9)";maxScroll = "(-7,+22)";}generateTest("innerScrollbars_none", maxScroll, minScroll);})
 FAILED test: ../../dijit/tests/_base/test_scroll.html::dijit._base.scroll::test_innerScrollbars_none 72 ms
     _AssertFailure: http://localhost/trunk2/dojo/_base/_loader/bootstrap.js:538 doh._AssertFailure: assertEqual() failed:
  expected (+9,+11) but got (+1,+1)
 doh._AssertFailure
     ERROR IN:
  (function test_innerScrollbars_loose_rtl() {var minScroll, maxScroll;if (dojo.isIE <= 6) {minScroll = "(+32,+11)";maxScroll = "(-32,+21)";} else if (dojo.isIE == 7) {minScroll = "(+31,+10)";maxScroll = "(-31,+21)";} else if (dojo.isIE) {minScroll = "(-20,+11)";maxScroll = "(-9,+22)";} else if (dojo.isFF < 3) {minScroll = "(-20,+12)";maxScroll = "(-10,+22)";} else if (dojo.isFF) {minScroll = "(+9,+11)";maxScroll = "(+20,+22)";} else if (dojo.isWebKit) {minScroll = "(+7,+9)";maxScroll = "(+20,+22)";}generateTest("innerScrollbars_loose_rtl", maxScroll, minScroll);})
 FAILED test: ../../dijit/tests/_base/test_scroll.html::dijit._base.scroll::test_innerScrollbars_loose_rtl 115 ms

Looks like the same errors also appear when running test_scroll.html directly.

This is with firebug enabled (not sure if that's connected).

Tests are running correctly on FF3/windows.

Change History (2)

comment:1 Changed 11 years ago by Douglas Hays

Status: newassigned

Verified FF3.0.6 on Windows works, on Mac doesn't. That's not supposed to happen, to my knowledge.

comment:2 Changed 11 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

(In [16687]) Fixes #8633 !strict. Allow for scrollbar of any size (fractions of a pixel in FF with max zoom up to 34 pixels with min zoom). Adjust test to work with different scrollbar sizes. Note that test_scroll.html currently only reports correct pixel values for unzoomed env.

Note: See TracTickets for help on using tickets.