Opened 10 years ago

Closed 10 years ago

#8592 closed enhancement (fixed)

Badge margin settings are explicitly declared in source - Request for API parameter - marginwidth

Reported by: David Leonardi Owned by: dante
Priority: high Milestone: 1.4
Component: DojoX Widgets Version: 1.2.3
Keywords: dojox.badge badge border Cc:
Blocked By: Blocking:

Description

Using current dojox.badge, the margin settings between one cell and the others are explicitly set to 1px, in source, and in case larger borders are defined source modifications are necessary to get the required effect and have cells aligned properly.

It would be reccomended to have an external parameter to pass to the widget, for instance "cellmargin", with a default to 1 if it is not passed.

The same considerations could also apply to border and padding settings.

Change History (3)

comment:1 Changed 10 years ago by dante

Milestone: tbd1.5

sounds good. not today. :)

comment:2 Changed 10 years ago by dante

Milestone: 1.51.4
Status: newassigned

@Seth - about to land this adjustment. Perhaps you can make up a demo showing larger/smaller margins? Defaults left in place.

comment:3 Changed 10 years ago by dante

Resolution: fixed
Status: assignedclosed

(In [20166]) fixes #8592 - allow a param for adjusting based on css margins

Note: See TracTickets for help on using tickets.