Opened 11 years ago

Closed 11 years ago

Last modified 8 years ago

#8557 closed defect (fixed)

[patch] [ccla] dnd feedback relies on color only and is not accessible

Reported by: Becky Gibson Owned by: Becky Gibson
Priority: high Milestone: 1.4
Component: DnD Version: 1.2.3
Keywords: a11y Cc: Becky Gibson, Nathan Toone
Blocked By: Blocking:

Description

The only indication that a user can not drop is a change in background color from green to red - this is not accessible since it relies on only color. We should change the icon in addition to the color.

Attachments (2)

dndNoMove.png (991 bytes) - added by Becky Gibson 11 years ago.
updated nomove icon
dndNoCopy.png (1.3 KB) - added by Becky Gibson 11 years ago.
updated no copy so it is a bit cleaner

Download all attachments as: .zip

Change History (15)

comment:1 Changed 11 years ago by Becky Gibson

Since this is an accessibility issue I marked it as high - it would be great if this could be addressed for 1.3

comment:2 Changed 11 years ago by Eugene Lazutkin

Owner: changed from Eugene Lazutkin to Becky Gibson

Actually DnD is not relying on colors --- it operates with CSS classes. It is up to a designer to interpret them differently, e.g., change an icon anywhere, or even show some suggestive text when certain CSS classes are defined.

comment:3 Changed 11 years ago by Becky Gibson

but our default css classes should be accessible. The default implementation relies on CSS background images which use only a change in color. And, we need to provide default text equivalents for those background images - see #8559

comment:4 Changed 11 years ago by Eugene Lazutkin

In this case isn't it better to assign the ticket to theme designers? BTW, there is a ticket #6240 to add DnD CSS classes to themes.

comment:5 Changed 11 years ago by bill

IIRC Nikolai made those images.... probably just need to change the red arrow to an X or a circle with a backslash.

comment:6 Changed 11 years ago by dante

Milestone: tbdfuture

are there waiRoles defined for states of Drag and Drop that we could emulate? we could decorate the avatar (by default a table)

Changed 11 years ago by Becky Gibson

Attachment: dndNoMove.png added

updated nomove icon

comment:7 Changed 11 years ago by Becky Gibson

Cc: Nathan Toone added
Summary: dnd feedback relies on color only and is not accessible[patch] [ccla] dnd feedback relies on color only and is not accessible

I have created updated icons for nomove and nocopy. I'm not a photoshop whiz so these may need additional tweaking. I am suggesting a solid bar with a red background for nomove and an x with red background for no copy.

comment:8 Changed 11 years ago by Nathan Toone

This still doesn't address a11y fully, does it? Since it still relies on background images only?

comment:9 Changed 11 years ago by Becky Gibson

this patch fixes the color issue so the people who can't interpret color differences can still understand the standard icons. The rest of the a11y issue is addressed in #8559 for people with more severe vision problems who turn off images or use high contrast mode. If high contrast /no images mode is detected then we use text characters.

Changed 11 years ago by Becky Gibson

Attachment: dndNoCopy.png added

updated no copy so it is a bit cleaner

comment:10 Changed 11 years ago by Becky Gibson

if these new icons are acceptable I'd like to get this checked in. green plus - copy okay red x - no copy green arrow - move okay red bar - no move

comment:11 Changed 11 years ago by Becky Gibson

Resolution: fixed
Status: newclosed

(In [17300]) fixes #8557 #8559 replace the icons that only use color with new icons that use color and different shapes. Also provide text only equivalents for when system is in high contrast mode.

comment:12 Changed 11 years ago by Adam Peller

Milestone: future1.4

comment:13 Changed 8 years ago by bill

In [28179]:

Accessible DnD images for dijit themes, fixes #15025, refs #8557.

Note: See TracTickets for help on using tickets.