Opened 11 years ago

Closed 8 years ago

#8547 closed defect (fixed)

Allow Sizzle as a query build option for dojo

Reported by: James Burke Owned by: James Burke
Priority: high Milestone: 1.4
Component: Query Version: 1.2.3
Keywords: Cc:
Blocked By: Blocking:

Description

Allow Dojo to be built with the Sizzle query engine.

Change History (8)

comment:1 Changed 11 years ago by James Burke

(In [16521]) Refs #8547, allow sizzle as a build option replacement for normal dojo query engine. Still some rough edges/behavior differences, and want to be sure this is the best way to integrate. \!strict

comment:2 Changed 11 years ago by alex

(In [16533]) make sue that query-sizzle.js can still run stand-alone (for side-by-side perf tests). Refs #8547 !strict

comment:3 Changed 11 years ago by James Burke

(In [16594]) Refs #8547, get the sizzle wrapper to do more of dojo.query-like work when query is not a string, then for both acme and sizzle, make sure the dojo detection works with multiversion support. \!strict for sizzle code

comment:4 Changed 11 years ago by dante

so this works but isn't complete? we'll need to document the build step. sajenkins is working on covering all built use cases, and this seems to fit.

comment:5 Changed 10 years ago by bill

James said he has left this open because:

just wanted to give feedback to sizzle on our test failures, i think it is just selector support mismatch perhaps. haven't locked it down, but i would not consider it a blocker

comment:6 Changed 10 years ago by James Burke

Milestone: 1.4future

comment:7 Changed 10 years ago by bill

Component: CoreQuery

comment:8 Changed 8 years ago by bill

Milestone: future1.4
Resolution: fixed
Status: newclosed

I'm going to mark this as fixed. We support sizzle now, although it's become less important with querySelectorAll() and the lite engine from Kris. Would be nice to report any test failures but that should go into the sizzle bug database, not this one.

Note: See TracTickets for help on using tickets.