#8536 closed defect (fixed)
InlineEditBox: Save when validation hasn't passed
| Reported by: | skaterkfbs | Owned by: | Douglas Hays |
|---|---|---|---|
| Priority: | high | Milestone: | 1.4 |
| Component: | Dijit | Version: | 1.2.3 |
| Keywords: | InlineEditBox, validation | Cc: | |
| Blocked By: | Blocking: |
Description (last modified by )
In an InlineEditBox you shouldn't be able to save the value until the editor has been validated. There is code checking this in the _onChange function but not in the _onKeyPress function.
Attachments (1)
Change History (9)
comment:1 Changed 12 years ago by
| Description: | modified (diff) |
|---|---|
| Owner: | set to Douglas Hays |
comment:2 Changed 12 years ago by
| Milestone: | tbd → 1.3 |
|---|---|
| Status: | new → assigned |
comment:3 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:4 Changed 12 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
What about the situation when:
autoSave: true
now, when you pres enter value onChange is fired with new wrong value. Better situation is when old value replace the new wron one. Attached patch do this.
Changed 12 years ago by
| Attachment: | InlineEditBox.patch added |
|---|
comment:5 follow-up: 8 Changed 12 years ago by
mgolebsk, please don't reopen old tickets since there's no way to add fixing multiple milestones in trac.
comment:7 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
comment:8 Changed 12 years ago by
Replying to doughays:
mgolebsk, please don't reopen old tickets since there's no way to add fixing multiple milestones in trac.
OK, I will create new ticket in such case.
Note: See
TracTickets for help on using
tickets.
[16506] Fixes #8536. _onKeyPress now calls _onChange since it handles the Save button state better.