Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#8536 closed defect (fixed)

InlineEditBox: Save when validation hasn't passed

Reported by: skaterkfbs Owned by: Douglas Hays
Priority: high Milestone: 1.4
Component: Dijit Version: 1.2.3
Keywords: InlineEditBox, validation Cc:
Blocked By: Blocking:

Description (last modified by bill)

In an InlineEditBox you shouldn't be able to save the value until the editor has been validated. There is code checking this in the _onChange function but not in the _onKeyPress function.

Attachments (1)

InlineEditBox.patch (1.3 KB) - added by Marcin Gołębski 10 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 10 years ago by bill

Description: modified (diff)
Owner: set to Douglas Hays

comment:2 Changed 10 years ago by Douglas Hays

Milestone: tbd1.3
Status: newassigned

comment:3 Changed 10 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

[16506] Fixes #8536. _onKeyPress now calls _onChange since it handles the Save button state better.

comment:4 Changed 10 years ago by Marcin Gołębski

Resolution: fixed
Status: closedreopened

What about the situation when:

autoSave: true

now, when you pres enter value onChange is fired with new wrong value. Better situation is when old value replace the new wron one. Attached patch do this.

Changed 10 years ago by Marcin Gołębski

Attachment: InlineEditBox.patch added

comment:5 Changed 10 years ago by Douglas Hays

mgolebsk, please don't reopen old tickets since there's no way to add fixing multiple milestones in trac.

comment:6 Changed 10 years ago by Douglas Hays

Milestone: 1.31.4

Partially fixed in 1.3 AND 1.4.

comment:7 Changed 10 years ago by Douglas Hays

Resolution: fixed
Status: reopenedclosed

(In [20449]) Fixes #8536. Check enableSave() before calling save(). Add robot test for same.

comment:8 in reply to:  5 Changed 10 years ago by Marcin Gołębski

Replying to doughays:

mgolebsk, please don't reopen old tickets since there's no way to add fixing multiple milestones in trac.

OK, I will create new ticket in such case.

Note: See TracTickets for help on using tickets.