Opened 10 years ago

Closed 6 years ago

#8534 closed defect (wontfix)

dojox.storage.manager.addOnLoad(handler); handler may be multiply called

Reported by: dtgriscom Owned by: Shane O'Sullivan
Priority: low Milestone: 1.9
Component: Storage/Flash Version: 1.2.3
Keywords: storage addOnLoad needsreview Cc:
Blocked By: Blocking:

Description

Each time you call addOnLoad(listener), listener is added to the _onLoadListeners list, and then if dojox.storage.manager is already initialized then _fireLoaded() is called so that the listener is always called. Problem: _fireLoaded() calls all the listeners in _onLoadListeners, but does NOT remove them from the list. This means that, once the manager is initialized, each call to addOnLoad() results in all previous listeners being called again.

Fix: _fireLoaded() should delete each listener from _onLoadListeners before calling the listener.

Change History (4)

comment:1 Changed 10 years ago by dante

Milestone: tbdfuture

comment:2 Changed 10 years ago by Adam Peller

Owner: changed from bradneuberg to Shane O'Sullivan

Thank you, Shane

comment:3 Changed 7 years ago by ben hockey

Keywords: needsreview added
Priority: highlow

comment:4 Changed 6 years ago by dylan

Milestone: future1.9
Resolution: wontfix
Status: newclosed

dojox/storage is abandoned/deprecated (work is being done on various modules to support local storage). Closing as wontfix.

Note: See TracTickets for help on using tickets.