Opened 11 years ago

Closed 11 years ago

#8523 closed defect (fixed)

[patch][cla] Tree: DND moving out of container "this.avatar is null" error

Reported by: millennium Owned by:
Priority: high Milestone: 1.3
Component: Dijit Version: 1.2.3
Keywords: tree, dnd, avatar Cc:
Blocked By: Blocking:

Description

dijit/_tree/dndSource.js (line: 415)

var m = dojo.dnd.manager();
m.canDrop(false);
m.outSource(this);

This part gives an "this.avatar is null" error after moving out of the DNDContainer/tree after an DND action. Which gives a JS error in IE. It should check if we're still Dragging. like:

var m = dojo.dnd.manager();
if(this.isDragging){
  m.canDrop(false);
}  
m.outSource(this);

(Somebody needs to tell me how to make a diff in Win32)

Change History (2)

comment:1 Changed 11 years ago by millennium

Version 1.2.3 must be Nightly build 2009-01-24

comment:2 Changed 11 years ago by bill

Resolution: fixed
Status: newclosed

(In [16503]) Fixes #8523: [patch][cla] Tree: DND moving out of container "this.avatar is null" error

Thanks to millennium (CLA on file) for catching the bug and supplying patch.

!strict

Note: See TracTickets for help on using tickets.