Opened 11 years ago

Closed 7 years ago

#8509 closed defect (patchwelcome)

IE8: header highlighting too short

Reported by: bill Owned by:
Priority: blocker Milestone: future
Component: DojoX Grid Version: 1.2.3
Keywords: Cc:
Blocked By: Blocking:

Description

See demos/mail/demo.html. The column headers (Sender, Subject, Date) are too short, leaving a white area beyond it:

screen shot of IE8 problem

Work OK except for IE8 RC1.

Attachments (1)

grid.png (5.5 KB) - added by bill 11 years ago.
screen shot of IE8 problem

Download all attachments as: .zip

Change History (13)

Changed 11 years ago by bill

Attachment: grid.png added

screen shot of IE8 problem

comment:1 Changed 11 years ago by Bryan Forbes

Milestone: tbd1.3
Priority: normalhigh

comment:2 Changed 11 years ago by bill

Milestone: 1.31.4

1.3rc1 has been release; bumping remaining tickets to 1.4 (except for documentation/testing tickets)

comment:3 Changed 10 years ago by Phil DeJarnett

I can confirm this, although it appears to be the actual size of the <th>, not just the background.

comment:4 Changed 10 years ago by Phil DeJarnett

Update: This only affects columns that do not have an explicit width. In other words, if the columns have a percent or "auto" width, they render incorrectly, but ems and other units appear to work fine.

comment:5 Changed 10 years ago by Phil DeJarnett

Update 2: I just noticed this only appears when the page is in Standards Mode. If you don't include a doctype, the table does not have the gaps. of course, everything else goes to heck, too...

As far as I can tell, sadly, this might actually be some kind of weird bug in IE8 itself.

I've tried disabling all of the grid styles, one-by-one, and none of them caused the weird gaps to disappear. Something along the way did, but I never was able to determine what, because IE started getting really buggy as I disabled styles.

The frustrating thing is that this is the only real object preventing me from defaulting to IE8.

comment:6 Changed 10 years ago by Phil DeJarnett

I did a little more research on this. I can make the gaps disappear with this CSS:

/* fixes IE8 table headers */
.dojoxGridHeader th {
	padding-right: 0 !important;
	padding-left: 0 !important;
}

However, two problems arise: 1) The header have no padding, and look awful (obvious, possibly fixable by adding padding to the inner DIV)

2) The headers no longer line up with the body.

I haven't figured out how to test this, but I think the problem might be related to having the header content inside a DIV? Alternatively, there could be an issue with the width calculation.

Hopefully this helps narrow down this annoying bug that keeps my website in IE7 Standards mode. :-/

comment:7 in reply to:  6 Changed 10 years ago by Diego Osse Fernandes

OverZalous?,

I use this CSS and work fine:

/* fixes IE8 table headers */
.dojoxGridCell {
	padding-right: 0 !important;
	padding-left: 0 !important;
}

Replying to OverZealous:

I did a little more research on this. I can make the gaps disappear with this CSS:

/* fixes IE8 table headers */
.dojoxGridHeader th {
	padding-right: 0 !important;
	padding-left: 0 !important;
}

However, two problems arise: 1) The header have no padding, and look awful (obvious, possibly fixable by adding padding to the inner DIV)

2) The headers no longer line up with the body.

I haven't figured out how to test this, but I think the problem might be related to having the header content inside a DIV? Alternatively, there could be an issue with the width calculation.

Hopefully this helps narrow down this annoying bug that keeps my website in IE7 Standards mode. :-/

comment:8 Changed 10 years ago by Nathan Toone

Milestone: 1.41.5
Owner: changed from Bryan Forbes to Nathan Toone

I'll take a look at this one.

comment:9 Changed 9 years ago by Nathan Toone

Milestone: 1.5future
Owner: Nathan Toone deleted

Moving my tickets to future, as I am not currently working on them.

comment:10 Changed 8 years ago by Colin Snover

Priority: highblocker

Bulk update of open ticket priorities.

comment:11 Changed 7 years ago by bill

DojoX Grid and EnhancedGrid are deprecated in favor of dgrid and gridx.

You should upgrade your code to use one of those two grids.

We will consider patches to the old DojoX Grid code though.

comment:12 Changed 7 years ago by bill

Resolution: patchwelcome
Status: newclosed
Note: See TracTickets for help on using tickets.