Opened 12 years ago
Closed 12 years ago
#8506 closed defect (fixed)
Adjust dojo.isIE when EmulateIE7 header is in use
Reported by: | James Burke | Owned by: | James Burke |
---|---|---|---|
Priority: | high | Milestone: | 1.3 |
Component: | Core | Version: | 1.2.3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
As opposed to the user clicking the compatibility button in IE8, if the web site uses the EmulateIE7 header/META tag, then we should adjust the isIE to match. Something like:
if(dojo.isIE >= 8 && document.documentMode == 7){ dojo.isIE = 7; }
Bill said Cougar needs to know real IE version for some emulation quirks in rich text editing. In the above case, define a isRealIE property with the originally detected version of IE.
See this list discussion for more info: http://thread.gmane.org/gmane.comp.web.dojo.devel/9708
Change History (3)
comment:1 Changed 12 years ago by
comment:2 Changed 12 years ago by
Bill, OK in that case I am not sure we have something we can test that will tell us we are in emulation mode: when that compat button is pressed, then IE changes the user agent too.
If Cougar has a reproducible case, he can pass to me, and I'll see if I can get it to Microsoft for their evaluation.
The more I think about it, I do not think we should provide a "realIE" flag. IE not changing the navigator.userAgent with x-ua-compatible is used may be a bug (it does for the compat button). I'll see if I can ask Microsoft about that.
So for now, I'll just set isIE to the documentMode unless documentMode is 5, quirks mode, and leave out an realIE value.
comment:3 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
SVN sync not working, fixed in [16517].
FYI when you actually press the IE7-emulate button in IE then dojo.isIE is set to 7 (as one would expect).... and I think that was the case that Cougar was actually talking about.
But in short, in both cases, dojo.isIE should state the emulated version, and dojo.isRealIE (or a less confusing name like dojo.realIE, we should probably get rid of all the "is" words in 2.0) should state the real version.