Opened 11 years ago

Closed 11 years ago

#8505 closed defect (fixed)

RadioGroupFade (programmatically) creates the titles in double

Reported by: Kenny Owned by: dante
Priority: high Milestone: 1.3
Component: Dojox Version: 1.2.3
Keywords: Cc:
Blocked By: Blocking:

Description

Hello,

I have 2 contentPäne with title inside my RadioGroupFade? with hasButtons to true and it shows me 2 times each title.

Kenny

Attachments (2)

1.php (1.7 KB) - added by Kenny 11 years ago.
test RadioGroupFade?
RadioGroup.patch (8.4 KB) - added by dante 11 years ago.
fixes everything i think

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by Kenny

Attachment: 1.php added

comment:1 Changed 11 years ago by Adam Peller

Owner: changed from Adam Peller to dante

comment:2 Changed 11 years ago by Kenny

The problem, with my example at least, is that I do a addChild before the startup function on the RadioGroupFade? widget. So the _makeButtons is called twice. Via the startup function and via the addChild function.

If I put my addchild functions after the startup, no problem. The _makeButtons function is only called via the addChild function. During startup call, there aren't any children (yet).

Kenny

comment:3 Changed 11 years ago by bill

Looks to me like in RadioGroup.js, _makeButton should be called _setupChild so that it's called for the initial children and the children added via addChild() (both before and after startup()).

comment:4 Changed 11 years ago by dante

Milestone: tbd1.3
Status: newassigned

this is a regression. leaving for 1.3 fixing.

Changed 11 years ago by dante

Attachment: RadioGroup.patch added

fixes everything i think

comment:5 Changed 11 years ago by dante

Resolution: fixed
Status: assignedclosed

(In [16689]) fixes #8505 - RadioGroup? adjustment to handle native addChild/_setupChild with buttons to prevent duplicate buttons being made. !strict

Note: See TracTickets for help on using tickets.