Opened 13 years ago
Closed 10 years ago
#8496 closed task (fixed)
shave some bytes from dojo.io.iframe
Reported by: | Douglas Hays | Owned by: | James Burke |
---|---|---|---|
Priority: | low | Milestone: | 1.5.2 |
Component: | IO | Version: | 1.2.3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
The method _fireNextRequest in dojo/io/iframe contains
if(dojo.isIE){ tn = dojo.doc.createElement("<input type='hidden' name='"+name+"'>"); }else{ tn = dojo.doc.createElement("input"); tn.type = "hidden"; tn.name = name; }
but this should just be
tn = dojo.doc.createElement("input"); tn.type = "hidden"; tn.name = name;
The type and name can be set as long as the node isn't added to the body yet. Similar code is done in dijit.form.MappedTextBox? without problems. This is probably a carryover from IE5 days.
Change History (4)
comment:1 Changed 13 years ago by
comment:2 Changed 13 years ago by
Owner: | changed from anonymous to James Burke |
---|
comment:3 Changed 13 years ago by
Milestone: | tbd → future |
---|
comment:4 Changed 10 years ago by
Component: | Core → IO |
---|---|
Milestone: | future → 1.5.2 |
Resolution: | → fixed |
Status: | new → closed |
Fixed by me in [23745].
Note: See
TracTickets for help on using
tickets.
using dojo.create would save a few more bytes