Opened 11 years ago

Closed 11 years ago

#8495 closed defect (fixed)

[patch][ccla]dojo.io.iframe hidden iframe not actually hidden

Reported by: Douglas Hays Owned by: James Burke
Priority: high Milestone: 1.3
Component: Core Version: 1.2.3
Keywords: Cc:
Blocked By: Blocking:

Description

The iframe created by dojo.io.iframe needs to be hidden so that web pages don't render unexpectedly. Prior to [11393]/[11405], it was hidden (position:absolute). The condition in create() used to be

if(!dojo.isSafari)

but this was incorrectly changed to

if(dojo.isSafari < 3)

but that conditional is backwards. It should have been position:absolute for everything BUT Safari 2:

if(!(dojo.isSafari < 3))

I'd like to get this fixed in 1.3.

Attachments (2)

8495.html (1.2 KB) - added by Douglas Hays 11 years ago.
testcase showing problem
8495.patch (399 bytes) - added by Douglas Hays 11 years ago.
fix to be reviewed

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by Douglas Hays

Attachment: 8495.html added

testcase showing problem

Changed 11 years ago by Douglas Hays

Attachment: 8495.patch added

fix to be reviewed

comment:1 Changed 11 years ago by Douglas Hays

Summary: dojo.io.iframe hidden iframe not actually hidden[patch][ccla]dojo.io.iframe hidden iframe not actually hidden

comment:2 Changed 11 years ago by James Burke

Milestone: tbd1.3

comment:3 Changed 11 years ago by James Burke

Fixed in [16469], thanks for the patch and test case!

comment:4 Changed 11 years ago by James Burke

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.