Opened 10 years ago

Closed 8 years ago

#8485 closed defect (duplicate)

check code which generates id to remove spaces

Reported by: Becky Gibson Owned by: bill
Priority: high Milestone: future
Component: Accessibility Version: 1.2.3
Keywords: Cc: Joseph Scheuhammer
Blocked By: Blocking:

Description

The HTML spec says that id attributes should not have spaces. There are places in the dijit code where we generate ids to set up a labelledby relationship. As long as the item we are generating an id for does not already have an id OR it is an element that was generated by dijit, we need to replace any spaces with underscore. This was the cause of #8281. We were generating an id from the widget id. It happens that the widget id had a space in it and the labelledby relationship we were setting up did not work because Firefox 2 adheres to the spec and does not honor an id with spaces in it. We can't change the widget id since it may have been specified by a developer, but we should make certain that any generated ids do not include a space.

This likely to occur within the dijit code where we assigned aria labelledby or describedby attributes.

Change History (4)

comment:1 Changed 10 years ago by bill

FYI, for the 2.0 timeframe I'd like to disallow spaces in id's altogether. I filed #8289 to track that. But in the meantime this change makes sense.

comment:2 Changed 10 years ago by Becky Gibson

Milestone: 1.4future

comment:3 Changed 8 years ago by Chris Mitchell

Owner: changed from Becky Gibson to bill

reassign due to inactive committer. please triage accordingly.

comment:4 Changed 8 years ago by bill

Resolution: duplicate
Status: newclosed

Dup of #8489.

Note: See TracTickets for help on using tickets.