#8484 closed defect (fixed)
form widgets submit values even if name is not specified
Reported by: | Douglas Hays | Owned by: | Douglas Hays |
---|---|---|---|
Priority: | high | Milestone: | 1.3 |
Component: | Dijit | Version: | 1.2.3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
The form widgets have name="${name}" in their templates. This causes values to be submitted to the server even when there's no name value set. This can cause too much data to be sent on the wire, and can confuse server agents. This is a regression from 1.1.
Attachments (2)
Change History (9)
Changed 12 years ago by
Attachment: | 8484.patch added |
---|
comment:1 Changed 12 years ago by
This was originally from #8117 but I closed that as a duplicate (even though it's actually the original ticket).
Changed 12 years ago by
Attachment: | 8484_attrMap.patch added |
---|
alternate fix using Bill's changes to buildRendering/attributeMap - added benefit of removing _displayed_ value submitted on IE
comment:2 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
[16468] Fixes #8484. Add _setNameAttr method to _FormWidget that sets the name attribute on either valueNode/focusNode/domNode. Change buildRendering so that the widget domNode is not added until after _applyAttributes since name cannot be removed once in the DOM on IE. Changed _MappedTextBox so that there's no displayed text field submitted for IE users.
comment:4 Changed 12 years ago by
comment:5 Changed 12 years ago by
(In [16716]) Setting the name attribute after the widget DOM is created, even though it's not attached to <body>, causes subtle problems on IE. Specifically, dojo.query() and getElementsByTagName() don't work. (Even though form submission and dojo.attr(node, 'name') still do work.)
Rollback [16468] and [16474], and implement different solution.
fix to be reviewed