AccordionContainer: messing up (one time of display bug)

[helloworld]

hi,

I encounter some issues in my real application, in order to simplify it I write a testcase with almost same logic. the issues of this testcase is:

1.after all loaded, two titles of accordionPane are with bold font, means two panes are selected at current time.

2.when you click add button, the sx pane has been added, but yz pane disppeared. only after you click some other panes, then yz pane can appear.

3.then, you click(select) the sx pane, then click del button, then click add button, then sx pane is messing up, and yz pane disppeared.

my real application with similar logic, but with some different issues :-(

1. the same issue with issue2 above.

in fact, in the test case, if we change the order of statements of add.

	dijit.byId("frameId").selectChild(dijit.byId("ad"));
        dijit.byId("frameId").addChild(ap4self,4);

to:

	dijit.byId("frameId").addChild(ap4self,4);
	dijit.byId("frameId").selectChild(dijit.byId("ad"));

then issue 2 doesn't exist. but still be here in my real application.

and I also think the order of statements should not make different results.

2.when I deleted the sx pane, there is a blank pane after the last pane, ie the yz pane. if you click other pane title, then this blank pane title disppear, means seem it's OK now.

different scenarios with different results. :-(

Thanks in advance.

[bill]

test case

[bill]

Thanks for the test case. (I've attached it rather than inlining it as per our convention).

I reproduced the problem about 2 panes being initially selected against 1.2, but it's working in trunk.

As for "yz" disappearing when you press the "add" button, I cannot reproduce that.

Anyway, can you try against trunk (you can download from nightly.dojotoolkit.org) to see if that fixes some/all of your problems?

[bill]

Let us know if there is still a problem on trunk.

[helloworld]

Replying to bill:

Let us know if there is still a problem on trunk.

sorry for the late reply.

seems better.

But if you

1. click the add button to add a new pane.
2. select the new adding pane.
3. delete the new adding pane.(I mean del the selected pane currently, ie the new adding pane)
4. click the add button again.
5. then display is wrong.

I will attache the ok.jpg and wrong.jpg as example.

[helloworld]

the display should be.

[helloworld]

the wrong display for the test senario.

[helloworld]

Replying to helloworld:

Replying to bill:

Let us know if there is still a problem on trunk.

sorry for the late reply.

seems better.

But if you

1. click the add button to add a new pane.
2. select the new adding pane.
3. delete the new adding pane.(I mean del the selected pane currently, ie the new adding pane)
4. click the add button again.
5. then display is wrong.

I will attache the ok.jpg and wrong.jpg as example.

some comments:

1. trunk is dojo-2009-02-04.tar.gz from ​http://archive.dojotoolkit.org/nightly/

2. IE6 and FF3 for test env.

and attache my test case again for reference.

[helloworld]

the test case file

[bill]

Ah OK, I see the bug. The child is getting both the dijitVisible and dijitHidden flag at the same time, will fix.

[bill]

(In [16557]) Fixes #8478: if a StackContainer? child is selected, then deleted, then readded, it will have both the dijitVisible and dijitHidden CSS classes applied.

Still unclear what should happen when I remove the child; I guess both CSS classes should be removed? For now just put a safeguard in _setupChild().

!strict.